agent-desktop/tests/unit/plugins/test_download_catalog.py

# -*- coding: utf-8 -*-
"""Unit tests for src/pineagents/plugins/download_catalog.py."""

from __future__ import annotations

from pineagents.plugins.download_catalog import (
    _PINEAGENTS_DEMO_OFFICIAL_PLUGINS,
    _is_entry_compatible,
    build_pineagents_plugin_catalog,
)


def test_entry_with_qwenpaw_version_compatible() -> None:
    entry = {
        "id": "demo",
        "version": "1.0.0",
        # Exclusive upper bound: current 2.1.0b1 is treated as 2.1.0.
        "qwenpaw_version": {"min": "1.1.6", "max": "2.2.0"},
    }
    assert _is_entry_compatible(entry) is True


def test_entry_with_qwenpaw_version_max_ignored() -> None:
    """Declared max must not exclude a newer running QwenPaw."""
    entry = {
        "id": "demo",
        "version": "1.0.0",
        "qwenpaw_version": {"min": "0.1.0", "max": "1.1.0"},
    }
    assert _is_entry_compatible(entry) is True


def test_entry_with_only_min_compatible() -> None:
    entry = {
        "id": "demo",
        "version": "1.0.0",
        # Derived exclusive max is 2.2.0 for min 2.1.0.
        "qwenpaw_version": {"min": "2.1.0"},
    }
    assert _is_entry_compatible(entry) is True


def test_entry_with_only_min_incompatible() -> None:
    entry = {
        "id": "demo",
        "version": "1.0.0",
        "qwenpaw_version": {"min": "3.0.0"},
    }
    assert _is_entry_compatible(entry) is False


def test_entry_without_version_constraints_is_compatible() -> None:
    entry = {
        "id": "demo",
        "version": "1.0.0",
    }
    assert _is_entry_compatible(entry) is True


def test_entry_with_malformed_qwenpaw_version_falls_to_legacy() -> None:
    """Non-dict qwenpaw_version falls back to min_version/max_version."""
    entry = {
        "id": "demo",
        "version": "1.0.0",
        "qwenpaw_version": "not-a-dict",
        "min_version": "1.0.0",
        "max_version": "2.2.0",
    }
    assert _is_entry_compatible(entry) is True


def test_entry_with_malformed_qwenpaw_version_no_legacy() -> None:
    """Non-dict qwenpaw_version with no legacy fields is compatible."""
    entry = {
        "id": "demo",
        "version": "1.0.0",
        "qwenpaw_version": "not-a-dict",
    }
    assert _is_entry_compatible(entry) is True


def test_legacy_min_version_compatible() -> None:
    """Legacy min_version within range is compatible."""
    entry = {
        "id": "demo",
        "version": "1.0.0",
        "min_version": "2.1.0",
    }
    assert _is_entry_compatible(entry) is True


def test_legacy_min_version_incompatible() -> None:
    """Legacy min_version above current QwenPaw is incompatible."""
    entry = {
        "id": "demo",
        "version": "1.0.0",
        "min_version": "3.0.0",
    }
    assert _is_entry_compatible(entry) is False


def test_legacy_min_max_version_compatible() -> None:
    """Legacy min+max still loads when min is satisfied (max ignored)."""
    entry = {
        "id": "demo",
        "version": "1.0.0",
        "min_version": "1.0.0",
        "max_version": "2.2.0",
    }
    assert _is_entry_compatible(entry) is True


def test_legacy_max_version_ignored() -> None:
    """Legacy max_version alone must not make an entry incompatible."""
    entry = {
        "id": "demo",
        "version": "1.0.0",
        "min_version": "0.1.0",
        "max_version": "1.0.0",
    }
    assert _is_entry_compatible(entry) is True


def test_entry_with_empty_dict_qwenpaw_version() -> None:
    """Empty dict qwenpaw_version triggers compat check with defaults."""
    entry = {
        "id": "demo",
        "version": "1.0.0",
        "qwenpaw_version": {},
    }
    # Empty dict is isinstance(dict) but has no min/max, should
    # still pass through PluginManifest validation or fallback gracefully
    result = _is_entry_compatible(entry)
    assert isinstance(result, bool)


def test_build_pineagents_plugin_catalog_shape() -> None:
    """Backend demo catalog returns the official-tab shape with flags."""
    result = build_pineagents_plugin_catalog()
    assert result["error"] is None
    plugins = result["plugins"]
    assert len(plugins) == len(_PINEAGENTS_DEMO_OFFICIAL_PLUGINS)
    for entry in plugins:
        assert entry["id"]
        assert entry["plugin_id"]
        assert entry["name"]
        assert isinstance(entry["description_i18n"], dict)
        assert entry["version"]
        assert entry["kind"]
        # installed/upgrade flags must be present and bool-like
        assert entry["installed"] in (True, False)
        assert entry["upgrade_available"] in (True, False)
        assert entry["install_url"].startswith("http")


def test_build_pineagents_plugin_catalog_installed_flag() -> None:
    """installed/upgrade flags are computed from the plugins directory."""
    from pineagents.plugins.download_catalog import _installed_plugin_ids

    result = build_pineagents_plugin_catalog()
    installed = _installed_plugin_ids()
    for entry in result["plugins"]:
        assert entry["installed"] == (entry["plugin_id"] in installed)