refactor: narrow web image input v1

packages/attachment/attachment-local/tests/index.spec.ts

@@ -1,5 +1,4 @@
 import { Context } from 'cordis'
-import { existsSync } from 'node:fs'
 import { mkdtemp, rm } from 'node:fs/promises'
 import { tmpdir } from 'node:os'
 import { join } from 'node:path'
@@ -7,8 +6,6 @@ import { describe, expect, it } from 'vitest'
 import LocalAttachmentStore, {
   DEFAULT_MAX_IMAGE_BYTES,
   DEFAULT_MAX_IMAGE_PIXELS,
-  DEFAULT_MAX_IMAGES_PER_MESSAGE,
-  DEFAULT_MAX_MESSAGE_IMAGE_BYTES,
 } from '../src/index.ts'
 
 describe('local attachment service', () => {
@@ -16,8 +13,6 @@ describe('local attachment service', () => {
     const service = new LocalAttachmentStore(new Context(), {})
     expect(service.imageLimits).toEqual({
       maxImageBytes: DEFAULT_MAX_IMAGE_BYTES,
-      maxImagesPerMessage: DEFAULT_MAX_IMAGES_PER_MESSAGE,
-      maxMessageImageBytes: DEFAULT_MAX_MESSAGE_IMAGE_BYTES,
       maxImagePixels: DEFAULT_MAX_IMAGE_PIXELS,
       mediaTypes: ['image/png', 'image/jpeg', 'image/webp', 'image/gif'],
     })
@@ -37,22 +32,4 @@ describe('local attachment service', () => {
       await rm(dshHome, { recursive: true, force: true })
     }
   })
-
-  it('validates without persisting: a rejected image leaves no storage root behind', async () => {
-    const dshHome = await mkdtemp(join(tmpdir(), 'dsh-attachment-validate-'))
-    try {
-      const service = new LocalAttachmentStore(new Context(), { dshHome })
-      expect(() => { service.validateImage({ data: Uint8Array.of(1, 2, 3), mediaType: 'image/png' }) })
-        .toThrow(/Unsupported or malformed image data/)
-      const valid = Uint8Array.from(Buffer.from(
-        'iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNk+A8AAQUBAScY42YAAAAASUVORK5CYII=',
-        'base64',
-      ))
-      expect(() => { service.validateImage({ data: valid, mediaType: 'image/png' }) }).not.toThrow()
-      // Validation is storage-free: nothing below the root may exist yet.
-      expect(existsSync(service.root)).toBe(false)
-    } finally {
-      await rm(dshHome, { recursive: true, force: true })
-    }
-  })
 })

packages/attachment/attachment-local/tests/store.spec.ts

@@ -28,8 +28,6 @@ const PNG = Uint8Array.from(Buffer.from(
 
 const LIMITS: ImageAttachmentLimits = {
   maxImageBytes: 1024,
-  maxImagesPerMessage: 2,
-  maxMessageImageBytes: 2048,
   maxImagePixels: 16,
   mediaTypes: ['image/png', 'image/jpeg', 'image/webp', 'image/gif'],
 }