Pine/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 1 Wiki Activity

refactor(picker): drive the Win32 dialog from a spawned child process

Browse Source 
The koffi IFileOpenDialog conversation runs in a spawned child process instead of a worker thread: the dialog is the child's first window, so Windows activates it without a foreground call, and a native fault stays contained to the child. The driver maps the child's message protocol onto a promise and services aborts by posting WM_CLOSE to the dialog thread's windows, killing the child when the close budget is exhausted. The built worker ships as lib/worker.cjs (the ./worker export) under plain node, and win32-dialog.spec.ts returns to the thread-safe pool.
This commit is contained in:
Huanqi Cao
2026-08-04 01:40:57 +08:00
parent bc9171337a
commit 4201eaed3f
8 changed files with 153 additions and 219 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/host/directory-picker-native/tests/built-worker.e2e.ts
+14 -11
View File
@@ -1,27 +1,30 @@
/**
* Keyless built-artifact guard (the `dsh-workflow-workerthread` built-worker
* shape): plain `worker_threads` loads `lib/worker.cjs` and the bundle reaches
* its real koffi requires. POSIX hosts prove the load path end to end through
* the deterministic ole32 rejection; win32 skips (a real dialog would open),
* where the win32-only smoke in win32-dialog.spec.ts covers the source plane
* instead. Skips until a build produces the artifact.
* shape): plain `node` runs `lib/worker.cjs` and the bundle reaches its
* real koffi requires. POSIX hosts prove the load path end to end through
* the deterministic ole32 rejection; win32 skips (a real dialog would
* open), where the win32-only smoke in win32-dialog.spec.ts covers the
* source plane instead. Skips until a build produces the artifact.
*/
import { spawn } from 'node:child_process'
import { existsSync } from 'node:fs'
import { fileURLToPath } from 'node:url'
import { Worker } from 'node:worker_threads'
import { describe, expect, it } from 'vitest'
import type { Win32DialogWorkerMessage } from '../src/win32-dialog-worker.ts'
const builtWorker = fileURLToPath(new URL('../lib/worker.cjs', import.meta.url))
describe.skipIf(!existsSync(builtWorker) || process.platform === 'win32')('built dialog worker (lib/worker.cjs)', () => {
it('loads under plain worker_threads and reports the native-surface failure', async () => {
it('loads under plain node and reports the native-surface failure', async () => {
const message = await new Promise<Win32DialogWorkerMessage>((resolve, reject) => {
const worker = new Worker(builtWorker, { workerData: { title: 'Built-artifact guard' } })
worker.on('message', resolve)
worker.on('error', reject)
worker.on('exit', (code) => {
const child = spawn(process.execPath, [builtWorker], {
env: { ...process.env, DSH_DIALOG_TITLE: 'Built-artifact guard' },
stdio: ['ignore', 'inherit', 'inherit', 'ipc'],
})
child.on('message', resolve)
child.on('error', reject)
child.on('exit', (code) => {
reject(new Error(`worker exited (${code}) before reporting`))
})
})