fix(web): correct the preset-layer contracts review found stale
None of these change behavior; each said something that was not true. `SessionCwdConflict`'s doc block had been left stranded above the `AgentPresetConflict` inserted under it, so one class carried a comment about the other and the second carried none. The roster comment named a `.system` directory that does not exist; the shipped root is `config/agent-presets/`, and `system` is the trust its entries carry. The real-composition test attributed the disabled `api-gateway` row to "side effects outside this process" alongside the port and the exporter. It is disabled for a different reason — the api-proxy cannot mount in this layer at all — and hiding that behind the same phrase would leave a later layer unable to tell whether the line can come out. One test claimed to refuse an adoption while asserting only that the header records the preset; it now says what it checks. `PERSONA_SECTION`/`PERSONA_ORDER` existed twice, once in the registry that declares the slot and once restated in the row that replaces it — a drift that would land a preset's persona beside the deployment's instead of shadowing it. The registry exports them now. The preset conflict message read "already runs agent preset undefined" for a session that records none, which is the shape a deployment with no roster produces; it names that case instead, with the regression that reaches it through the gateway. Finally, `PresetTree.write()` drops the `loader/config-update` the inherited method emits — recorded on the override, since a future edit-while-running flow needs its own persistence path.
This commit is contained in:
@@ -17,11 +17,12 @@ import type { Context } from 'cordis'
|
||||
import z from 'schemastery'
|
||||
import type {} from '@deepseek-ai/dsh-system-prompt'
|
||||
|
||||
/** The section name this plugin registers; the prompt registry's persona slot. */
|
||||
export const PERSONA_SECTION = 'deployment:persona'
|
||||
// Imported rather than restated: the registry declares the slot this row
|
||||
// replaces, and two hardcoded copies would drift into a preset whose persona
|
||||
// silently lands beside the deployment's instead of shadowing it.
|
||||
import { PERSONA_ORDER, PERSONA_SECTION } from '@deepseek-ai/dsh-system-prompt'
|
||||
|
||||
/** Prompt order of the persona slot, matching the registry's own default. */
|
||||
export const PERSONA_ORDER = 0
|
||||
export { PERSONA_ORDER, PERSONA_SECTION }
|
||||
|
||||
/** Cordis plugin name. */
|
||||
export const name = 'persona'
|
||||
|
||||
Reference in New Issue
Block a user