test(mode): record the plan-mode approve and keep-planning scenarios
The with-key recording session the RFC deferred. plan-mode is the 'plan' header class's pinning scenario and necessarily carries BOTH header shapes verbatim: the plan-shaped initial snapshot and the widened fallback snapshot the approved exit produces mid-turn — so the suite factory's pin guards relax from exactly-one to at-least-one header (the classmates' uniformity anchor is the pin's FIRST header; transition headers are legal only in the pin, matching the sandbox stack's precedent). plan-mode-reject pins the keep-planning branch: the corrective isError carries the reviewer's free-text feedback verbatim and the session stays in plan mode, one header, uniform with the pin. Recording notes, encoded in the prompts: the model is pinned to RELATIVE paths (a recorded absolute temp path neither replays on another host nor normalizes — the normalizers scrub the run's own cwd, not the recording's), and the recorded model never calls a filtered tool, so the gate's deny path stays pinned at the unit tier — that refusal is the behavior the soft layer exists to produce. The gen-tool-catalog meta-test pins exit_plan_mode in the harvested schema list.
This commit is contained in:
@@ -16,4 +16,4 @@ Drive it from Zed or any ACP client; the mode picker appears on the session. Swi
|
||||
|
||||
## Tests
|
||||
|
||||
`pnpm run test:snapshot` replays the keyless `modes-advertise` scenario: the `modes` advertisement on `session/new`, both `session/set_mode` round-trips with their optimistic `current_mode_update`, and the loud rejection of an unknown mode id, as committed wire bytes. The recorded plan-mode arc (explore → denied write → `exit_plan_mode` → scripted approve / keep-planning) awaits a with-key recording session; its deny/review texts are pinned at the unit tier meanwhile (`packages/mode/mode/tests`, `packages/ui/acp/tests/modes.spec.ts`).
|
||||
`pnpm run test:snapshot` replays three scenarios keyless. `modes-advertise` (authored): the `modes` advertisement on `session/new`, both `session/set_mode` round-trips with their optimistic `current_mode_update`, and the loud rejection of an unknown mode id, as committed wire bytes. `plan-mode` (recorded, the header pin): the full arc — setMode(plan), the plan-shaped initial header, the plan presented via `exit_plan_mode`, a scripted elicitation approve, the in-turn `mode/set` back and the widened fallback header, then a real edit under the restored toolset. `plan-mode-reject` (recorded): the keep-planning branch, whose corrective `isError` carries the reviewer's free-text feedback verbatim and leaves the session in plan mode. The gate's deny texts stay pinned at the unit tier (`packages/mode/mode/tests`).
|
||||
|
||||
Reference in New Issue
Block a user