bbde18caff
Four rounds of structural rework on the conversation surface, converging on one registration model for the whole client: - Review fixes: open() leaves the inject factory (SessionsService owns the semantic); ConversationService mounts via ctx.plugin(); the bespoke view registry retires into the 'conversation.view' list slot. - Ring alignment: createChatView factory retired (components get everything through checkable shares at the register call site); the hand-rolled t/i18n threading is deleted wholesale — a future framework-level i18n will supply t as a standard prop keyed by slot name, so no interim manual channel. - Toolview dissolution: ToolViewRegistry / ToolViewResolver / ToolViewOutlet / ctx.toolviews retire. Tool rows are entries of the 'conversation.chat.toolview' keyed slot (scope: session) declared by the chat entry; ToolRowOwnerProps is the unified owner payload; GenericToolCard becomes the call-site fallback; registrants are plain plugins (inject ['slots','conversation'] as the load-order seam); session-dimension dispatch moves into components (useSessions reads parentId); trajectory/waterfall gain same-shape slots the day they render tool rows (RendersCheck rejects empty declarations). Slot names mirror the composition path (<domain>.<entry>.<hole>). - Staging follows current: cell()/binding() are pure resolution (render-safe); the constructor subscribes to the list store and followCurrent opens the event window when the current session changes — staging IS the open signal, business verbs are the timing, React render/commit is decoupled from window lifecycle. A masked current (projection gap) keeps the stage untouched so deferred teardown semantics survive reconnects. Agent Note: .agents/notes/implemented/architecture/ 2026-07-23-toolview-dissolution.md (bilingual pair) records the decision, the four rejected alternatives, and the accepted semantic changes; the web client architecture note and packages/client/AGENTS.md carry the current-state narrative. Verified: typecheck 0, duplication 0 clones (478 files), full coverage run 6190 passed with zero threshold errors, knip 0, doc-sync 24/24, client aggregate tsc 0, render-count checks (one commit per chunk, zero row re-renders under streaming) green.
194 lines
8.8 KiB
TypeScript
194 lines
8.8 KiB
TypeScript
// @vitest-environment jsdom
|
|
import { afterEach, describe, expect, it, vi } from 'vitest'
|
|
import { cleanup, fireEvent, render } from '@testing-library/react'
|
|
|
|
afterEach(cleanup)
|
|
import type { RunningToolCall, ToolResultNode } from '@deepseek-ai/dsh-client-runtime/client'
|
|
import { classifyTool, toolRowModel } from '../src/client/contract/tool-call-model.ts'
|
|
import { AssistantMarkdown } from '../src/client/chat/AssistantMarkdown.tsx'
|
|
import { ToolRow } from '../src/client/chat/ToolRow.tsx'
|
|
import { GenericToolCard } from '../src/client/chat/GenericToolCard.tsx'
|
|
import type { ToolRowOwnerProps } from '@deepseek-ai/dsh-client-ui-conversation/client'
|
|
|
|
const running = (over?: Partial<RunningToolCall>): RunningToolCall => ({
|
|
callId: 'c1', name: 'bash', argsRaw: '{"command":"ls -la","description":"List files"}',
|
|
turn: 1, step: 1, callView: null, ...over,
|
|
})
|
|
|
|
const result = (over?: Partial<ToolResultNode>): ToolResultNode => ({
|
|
kind: 'tool-result', seq: 10, callId: 'c1',
|
|
call: { name: 'bash', argsRaw: '{"command":"ls -la","description":"List files"}' },
|
|
content: [], isError: false, callView: null, resultView: null, ...over,
|
|
})
|
|
|
|
describe('tool-call-model', () => {
|
|
it('classifies known tools and falls back to others', () => {
|
|
expect(classifyTool('bash')).toBe('bash')
|
|
expect(classifyTool('read')).toBe('read')
|
|
expect(classifyTool('web_fetch')).toBe('read')
|
|
expect(classifyTool('web_search')).toBe('search')
|
|
expect(classifyTool('grep')).toBe('search')
|
|
expect(classifyTool('write')).toBe('write')
|
|
expect(classifyTool('edit')).toBe('edit')
|
|
expect(classifyTool('todo_write')).toBe('others')
|
|
})
|
|
|
|
it('derives state across running/ok/error/interrupted', () => {
|
|
expect(toolRowModel('bash', running()).state).toBe('running')
|
|
expect(toolRowModel('bash', result()).state).toBe('ok')
|
|
expect(toolRowModel('bash', result({ isError: true })).state).toBe('error')
|
|
expect(toolRowModel('bash', result({ isError: true, error: { name: 'E', code: 'interrupted' } })).state).toBe('stopped')
|
|
})
|
|
|
|
it('derives the bash summary from description over command', () => {
|
|
const m = toolRowModel('bash', running())
|
|
expect(m.title).toBe('Bash')
|
|
expect(m.summary).toBe('List files')
|
|
expect(toolRowModel('bash', running({ argsRaw: '{"command":"pwd"}' })).summary).toBe('pwd')
|
|
})
|
|
|
|
it('keeps summaries single-line and falls back for opaque args', () => {
|
|
expect(toolRowModel('bash', running({ argsRaw: '{"command":"a\\nb"}' })).summary).toBe('a')
|
|
expect(toolRowModel('read', running({ name: 'read', argsRaw: '{"path":"/tmp/x.ts"}' })).summary).toBe('/tmp/x.ts')
|
|
expect(toolRowModel('write', running({ name: 'write', argsRaw: '{"file_path":"src/x.ts"}' })).summary).toBe('src/x.ts')
|
|
expect(toolRowModel('edit', running({ name: 'edit', argsRaw: '{"file_path":"src/x.ts"}' })).summary).toBe('src/x.ts')
|
|
// Others rows prefix the real tool name into the summary slot (figma-flows
|
|
// ruling: static "Tool call" title, name rides the mutable summary).
|
|
expect(toolRowModel('x', running({ argsRaw: '{"n":1}' })).summary).toBe('x · {"n":1}')
|
|
expect(toolRowModel('x', running({ argsRaw: 'not json' })).summary).toBe('x · not json')
|
|
expect(toolRowModel('x', running({ argsRaw: '' })).summary).toBe('x · c1')
|
|
expect(toolRowModel('', running({ argsRaw: '' })).summary).toBe('c1')
|
|
})
|
|
|
|
it('body pretty-prints JSON args, keeps raw non-JSON, null when empty', () => {
|
|
expect(toolRowModel('bash', running({ argsRaw: '{"a":1}' })).body).toBe('{\n "a": 1\n}')
|
|
expect(toolRowModel('bash', running({ argsRaw: 'raw' })).body).toBe('raw')
|
|
expect(toolRowModel('bash', running({ argsRaw: '' })).body).toBeNull()
|
|
expect(toolRowModel('bash', result({ call: null })).body).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe('ToolRow', () => {
|
|
const rowProps = {
|
|
variant: 'bash' as const, icon: <i data-testid="tool-icon" />, title: 'Bash',
|
|
summary: 'List files', body: '{\n "a": 1\n}', state: 'ok' as const,
|
|
}
|
|
|
|
it('renders leading icon, title and summary while collapsed', () => {
|
|
const view = render(<ToolRow {...rowProps} />)
|
|
expect(view.queryByTestId('tool-icon')).not.toBeNull()
|
|
expect(view.getByText('Bash')).toBeTruthy()
|
|
expect(view.getByText('List files')).toBeTruthy()
|
|
expect(view.container.querySelector('[aria-expanded]')?.getAttribute('aria-expanded')).toBe('false')
|
|
})
|
|
|
|
it('expanding swaps the leading slot to a chevron, hides summary, shows body', () => {
|
|
const view = render(<ToolRow {...rowProps} />)
|
|
fireEvent.click(view.container.querySelector('button')!)
|
|
expect(view.queryByTestId('tool-icon')).toBeNull()
|
|
expect(view.container.querySelector('svg')).not.toBeNull()
|
|
expect(view.queryByText('List files')).toBeNull()
|
|
expect(view.getByText(/"a": 1/)).toBeTruthy()
|
|
fireEvent.click(view.container.querySelector('button')!)
|
|
expect(view.queryByTestId('tool-icon')).not.toBeNull()
|
|
expect(view.getByText('List files')).toBeTruthy()
|
|
})
|
|
|
|
it('running and error states replace the icon with a StateDot', () => {
|
|
const runningView = render(<ToolRow {...rowProps} state="running" />)
|
|
expect(runningView.queryByTestId('tool-icon')).toBeNull()
|
|
expect(runningView.container.querySelector('[data-state="running"]')).not.toBeNull()
|
|
const errorView = render(<ToolRow {...rowProps} state="error" />)
|
|
expect(errorView.queryByTestId('tool-icon')).toBeNull()
|
|
})
|
|
|
|
it('non-expandable rows render a passive leading slot', () => {
|
|
const view = render(<ToolRow {...rowProps} body={null} />)
|
|
expect(view.container.querySelector('button')).toBeNull()
|
|
expect(view.queryByTestId('tool-icon')).not.toBeNull()
|
|
})
|
|
|
|
it('row click hands off to onOpenDetails; the expand toggle does not', () => {
|
|
const open = vi.fn()
|
|
const view = render(<ToolRow {...rowProps} onOpenDetails={open} />)
|
|
fireEvent.click(view.getByText('List files'))
|
|
expect(open).toHaveBeenCalledTimes(1)
|
|
fireEvent.click(view.container.querySelector('button')!)
|
|
expect(open).toHaveBeenCalledTimes(1)
|
|
})
|
|
})
|
|
|
|
describe('ThinkRow', () => {
|
|
it('expands from either Think or the reasoning summary', () => {
|
|
const view = render(
|
|
<AssistantMarkdown
|
|
blocks={[{ kind: 'reasoning', text: 'Inspect the session\nCheck persistence' }]}
|
|
streaming={false}
|
|
/>,
|
|
)
|
|
const row = view.getByRole('button')
|
|
|
|
fireEvent.click(view.getByText('Inspect the session'))
|
|
expect(row.getAttribute('aria-expanded')).toBe('true')
|
|
expect(view.getByText(/Check persistence/)).toBeTruthy()
|
|
|
|
fireEvent.click(view.getByText('Think'))
|
|
expect(row.getAttribute('aria-expanded')).toBe('false')
|
|
})
|
|
})
|
|
|
|
describe('GenericToolCard', () => {
|
|
const props = (toolName: string, block: RunningToolCall | ToolResultNode): ToolRowOwnerProps => ({
|
|
callId: 'c1', toolName, block, openDetails: vi.fn(),
|
|
})
|
|
|
|
it('renders the classified variant row from the frozen slice', () => {
|
|
const view = render(<GenericToolCard {...props('bash', result())} />)
|
|
expect(view.getByText('Bash')).toBeTruthy()
|
|
expect(view.getByText('List files')).toBeTruthy()
|
|
expect(view.container.querySelector('[data-variant="bash"]')).not.toBeNull()
|
|
})
|
|
|
|
it('unknown tools land on the others variant titled Tool call', () => {
|
|
const view = render(
|
|
<GenericToolCard {...props('todo_write', running({ name: 'todo_write', argsRaw: '{"note":"x"}' }))} />,
|
|
)
|
|
expect(view.getByText('Tool call')).toBeTruthy()
|
|
expect(view.container.querySelector('[data-variant="others"]')).not.toBeNull()
|
|
expect(view.container.querySelector('[data-state="running"]')).not.toBeNull()
|
|
})
|
|
|
|
it('renders edit with its dedicated title, icon variant, and path summary', () => {
|
|
const view = render(
|
|
<GenericToolCard {...props('edit', running({
|
|
name: 'edit',
|
|
argsRaw: '{"file_path":"src/x.ts","old_string":"before","new_string":"after"}',
|
|
}))} />,
|
|
)
|
|
expect(view.getByText('Edit')).toBeTruthy()
|
|
expect(view.getByText('src/x.ts')).toBeTruthy()
|
|
expect(view.container.querySelector('[data-variant="edit"]')).not.toBeNull()
|
|
expect(view.container.querySelector('svg')).not.toBeNull()
|
|
})
|
|
|
|
it('renders write with its dedicated title, icon variant, and path summary', () => {
|
|
const view = render(
|
|
<GenericToolCard {...props('write', running({
|
|
name: 'write',
|
|
argsRaw: '{"file_path":"src/x.ts","content":"hello"}',
|
|
}))} />,
|
|
)
|
|
expect(view.getByText('Write')).toBeTruthy()
|
|
expect(view.getByText('src/x.ts')).toBeTruthy()
|
|
expect(view.container.querySelector('[data-variant="write"]')).not.toBeNull()
|
|
expect(view.container.querySelector('svg')).not.toBeNull()
|
|
})
|
|
|
|
it('row click reaches openDetails', () => {
|
|
const p = props('bash', result())
|
|
const view = render(<GenericToolCard {...p} />)
|
|
fireEvent.click(view.getByText('List files'))
|
|
expect(p.openDetails).toHaveBeenCalledTimes(1)
|
|
})
|
|
})
|