ZiyaZhang
2.6 KiB
Agent Note: Remove the first-run beta notice
Status: implemented
English | 中文
Problem
Every GUI first launch opened with a full-viewport internal-test statement (内测声明): internal-beta framing plus instructions for enabling Session Log upload through DSH_TELEMETRY_MODE. Session telemetry already resolves to DISABLED when its mode is unset (telemetry default-off), so the only onboarding content about telemetry was a prompt explaining how to turn it on, and the internal-test framing itself must not ship in a release build.
Decision
This decision removed the first-run notice from the assembled product rather than rewording it. ui-settings-general seated no settings.onboarding step; the notice component, acknowledgement store, copy owner, and locale keys were deleted, while the Host kept the ui-onboarding namespace so stored documents remained valid. The later shared-modal product onboarding restores a new concise testing-stage notice in ui-settings-models, reusing that field and backend contract without restoring the removed takeover layout or telemetry instructions. Telemetry opt-in remains an explicit deployment environment choice documented in the CLI reference README; the restored notice says nothing about enabling it.
Alternatives considered
Keep the notice and only drop its telemetry paragraph. Rejected: the internal-test framing is what a release must not present, and a mandatory first-run interstitial with no material statement left is pure friction.
Ask for upload consent instead (a versioned consent step). Rejected for this release: a first-run question about enabling upload is still a telemetry prompt. A future consent flow can register through the unchanged settings.onboarding seam and use a fresh versioned field for re-acknowledgement.
Deregister the ui-onboarding namespace as well. Rejected: existing settings documents already carry the section, and the settings seam validates stored documents against registered namespaces; keeping the registration keeps those documents valid at no cost.
Consequences
This removal eliminated the full-viewport notice and its telemetry copy. The later restoration is intentionally a different presentation and copy revision: a shared modal precedes the inline credential dialog, the remote scenario again covers process-local acknowledgement, and the existing welcomeNoticeVersion field records the new copy version. The historical telemetry prompt remains absent.