Files

T

creatixchu 5f34f782fc fix(web): address the late review batch on context bodies

- Content blocks render in the order the model received them. Partitioning
  hoisted every unknown block past the text around it, so an interleaved log
  read back in an order the model never saw.
- A delta distinguishes a newly reconciled file from a rewritten one; `set`
  and `replace` already separate them at the producer, and collapsing both to
  "updated" misread a new file.
- The superseded note states current fact in its consequences and testing
  rather than keeping claims the implementation now contradicts, per
  implemented/AGENTS.md; the decision itself stays as the record of that
  change, with the supersession pointer above it.

2026-08-05 17:08:51 +08:00

3.4 KiB

Raw Blame History

Agent Note: Web UI drops steer entry and interjection chrome

Status: implemented

English | 中文

Problem

Mid-turn steering is a host/agent-loop capability (mode:'steer', durable steering/message). The Web product already locked the composer while a turn runs and never shipped a queue/steer menu, yet the client still threaded 'queue' | 'steer' through the input machine, conversation.send, and locale keys, and rendered consumed steering as a badged 「插话」/「Interjection」 bubble. That left a half-built UI surface: an unused submit mode, a product label for a gesture users cannot perform, and e2e goldens that pinned chrome the product does not own.

Decision

Keep host and runtime steering intact. Remove only the Web UI entry and chrome:

InputMachine / SessionInput / InputActions.submit / hub defaultSink are queue-only; they always call session.prompt(..., 'queue').
ConversationService.send(text) drops its mode argument and always queues.
MessageItem's steering arm still folds durable steering/message content into a plain right-aligned bubble (no badge, no user IconActions) so external/host steers stay visible on replay.
Delete message.steering locale strings and the unused badge CSS.
The web steering e2e still POSTs mode:'steer' over /api/session.prompt and asserts durable + model-visible obedience; it no longer expects interjection chrome. Update web input machine note fact lines to match.

Alternatives considered

Delete host steering entirely. Out of scope; the user asked only for Web UI display and entry. Agent-loop drain, session events, and the wire mode remain load-bearing for ACP/TUI/automation.

Hide steering/message from the transcript. Would lie on replay when an external client steers; rejected in favor of a plain bubble.

Keep the mode parameter but only ever pass 'queue'. Leaves dead API surface and tests that invent 'steer' paths the composer cannot reach.

Consequences

Superseded in part. Every clause in the Decision about the steer ENTRY, the queue/steer mode union, the interjection caption, its locale strings, and the goldens that pinned their absence no longer describes master — that is bullets 1 and 3 through 5. Composer steering shipped afterwards, and the context-source and steer marks decision then supplied the product decision this note's reintroduction clause required and owns the caption. The consequences and testing below state current fact.
Host steering ownership is unchanged: agent-loop drain, session events, and the wire mode remain load-bearing for ACP, automation, and any non-Web client.
ConversationService.send(text) still takes no mode and always queues; the composer's Steer gesture goes through session.prompt(mode: 'steer') instead.
steering/message still folds into the durable transcript, so an externally submitted steer stays truthful on replay. It now carries the interjection caption rather than rendering as a bare bubble.

Testing

packages/client/ui-conversation unit/jsdom coverage: input machine enter/sink, ConversationService routing, the MessageItem steering arm, InputBar submit.
apps/web/tests/steering.e2e.ts keyless replay plus its goldens, which now pin the caption.

3.4 KiB Raw Blame History