Tianyi Cui
e6fad266a6
Define the in-file RFC contract in docs/rfc/README.md § The file format: the header block (`# RFC: <title>` plus a dateless Status enum cross-checked against the lifecycle folder), the per-lifecycle body skeleton (a Problem opener everywhere; Proposal/Alternatives considered/ Acceptance criteria/Risks in proposed/; present-tense Decision/ Consequences with proposal-era headings banned in implemented/; the frozen proposal shape in rejected/), and a mandatory Alternatives considered section with a date-fenced grandfather comment for pre-format RFCs whose alternatives are not reconstructible from the record. Enforce it with a new doc-sync gate, scripts/verify-rfc-format.ts, and normalize all 112 RFCs to it: ~15 Status-line spellings collapse to the enum, 29 Context openers become Problem, the 39 legacy-format XXX debt markers are resolved and banned from reappearing, proposal-era sections in implemented RFCs are rewritten to shipped reality (including the web/fs/subagent seam RFCs' migration plans and test checklists, closing the doc-tiers deferred-work item on the web seam), every RFC gains an Alternatives considered section or the grandfather comment, and the bilingual pair is re-mirrored and re-recorded. Move the generated index tables out of README.md into a fully generated docs/rfc/INDEX.md — gen-rfc-index now writes the whole file, and verify-rfc-classification checks its freshness and rejects index-shaped rows in the curated README — which makes room for the format contract to live in the README front door instead of a separate FORMAT.md. The decision record, and the first RFC written in the new format, is docs/rfc/implemented/process/2026-07-05-uniform-rfc-format.md.
2.7 KiB
RFC: Drop ACP terminal _meta rendering
Status: rejected — Zed is the current target client, and the terminal _meta convention is intentional Zed UX with a plain ACP fallback for other clients.
Problem
The ACP bridge implements a Zed-specific terminal-card convention through _meta.terminal_info, _meta.terminal_output, and _meta.terminal_exit. The implemented rich ACP bash rendering RFC deliberately avoided ACP's client-side terminal/create because bash execution belongs in the harness, but still adopted the reference agents' display-only _meta convention. That gives a nicer Zed card at the cost of bridge state, capability negotiation, terminal ids, special update mapping, text fallback tests, and exit-pill parsing in dsh-tool-bash.
The fallback path already exists: render the tool call and completed output as normal ACP content blocks. Non-Zed clients rely on that path anyway, but the Zed terminal card is a current target-client feature rather than speculative decoration.
Proposal
Ignore clientCapabilities._meta.terminal_output and render bash results through the plain ACP content path. Keep execution agent-side through dsh-bash; only the display-specific terminal metadata is removed. A terminal card can return later if ACP standardizes agent-executed terminals or if the product decides Zed-specific display is worth the maintenance cost.
This proposal is narrower than collapsing tool-owned UI presentation: it keeps generic presentCall/presentResult if those survive, but removes the terminal sub-shape and _meta mapping.
Acceptance criteria
- ACP no longer reads or stores
_meta.terminal_outputcapability state. TerminalRendering, terminal ids, terminal cwd resolution, and_meta.terminal_*update mapping disappear from@deepseek-ai/dsh-acp.ToolTerminaldisappears from@deepseek-ai/dsh-tools, or is unused and deleted with the presentation cleanup.- Bash result presentation no longer parses exit status for terminal pills.
- The implemented rich ACP bash rendering RFC stays in
implemented/as shipped history and is cross-linked from this proposal if superseded.
What we give up
Zed users lose the dedicated terminal card: no cwd header, terminal display, or exit pill. They still see the command and output as plain content. That is a reasonable simplification while the ACP bridge is still unreleased and the _meta keys are a convention rather than a standard.