Yichen Jiang
e18aa2745c
A preset is now ONE composition per process, not one per session. The roster mounts it once under a synthetic standing scope; each agent joins by having its scope key parented to the mount's. Two mechanisms in dsh-scope carry the whole change: registration views walk the parent chain (global → preset → agent, nearest shadowing farthest — ScopedLayers.chainLayers), and scoped event dispatch admits a listener tagged with an ancestor of the carrier key, which is what lets a standing composition's plan/compaction/token listeners observe each agent composed under it while a sibling preset's stay deaf. The preset plugins already key their state by Session/Agent — they predate presets and were written for the shared world — so sharing one instance is a return to their design, not a rewrite. Preset ymls are unchanged: one mount per preset means one Entry per preset, whose entry-local realms keep two presets' services apart exactly as they kept two sessions' apart before. The standing scope hangs off the service's UNTRACED context (selfCtx): a method invoked through the traceable proxy sees this.ctx rebound to the caller and carrying its shadow, and a subtree minted from that resolves every service through the shadow's fiber instead of each entry's own inject store — preset rows then fail on the very services they declare. A standing mount survives its agents deliberately. The composition a running session joined must outlive the file changing or disappearing underneath it; reclamation happens at whole-tree teardown, and file edits reach only future generations (the authoring layer swaps the pointer, never disposes a joined generation).
88 lines
3.7 KiB
TypeScript
88 lines
3.7 KiB
TypeScript
import { dirname, join } from 'node:path'
|
|
import { fileURLToPath, pathToFileURL } from 'node:url'
|
|
import { Context } from 'cordis'
|
|
import Loader from '@cordisjs/plugin-loader'
|
|
import Include from '@cordisjs/plugin-include'
|
|
import LlmService from '@deepseek-ai/dsh-llm'
|
|
import SessionStore, { SessionId } from '@deepseek-ai/dsh-session'
|
|
import SystemPrompt from '@deepseek-ai/dsh-system-prompt'
|
|
import ToolRegistry from '@deepseek-ai/dsh-tools'
|
|
import AgentRegistry from '@deepseek-ai/dsh-agent'
|
|
import AgentLoop from '@deepseek-ai/dsh-agent-loop'
|
|
import InvariantService from '@deepseek-ai/dsh-invariants'
|
|
import { describe, expect, it } from 'vitest'
|
|
import AgentPresets, { livePresetMounts } from '@deepseek-ai/dsh-agent-presets'
|
|
import * as AgentPresetsInvariant from '@deepseek-ai/dsh-agent-presets/invariant'
|
|
|
|
const FIXTURES = join(dirname(fileURLToPath(import.meta.url)), 'fixtures')
|
|
const ROOTS = [
|
|
{ path: join(FIXTURES, 'system'), trust: 'system' as const },
|
|
{ path: join(FIXTURES, 'user'), trust: 'user' as const },
|
|
]
|
|
|
|
async function harness(): Promise<Context> {
|
|
const ctx = new Context()
|
|
ctx.baseUrl = pathToFileURL(FIXTURES).href + '/'
|
|
await ctx.plugin(Loader)
|
|
ctx.loader.builtins.include = Include
|
|
await ctx.plugin(LlmService)
|
|
await ctx.plugin(SessionStore)
|
|
await ctx.plugin(SystemPrompt, { persona: '' })
|
|
await ctx.plugin(ToolRegistry)
|
|
await ctx.plugin(AgentRegistry)
|
|
await ctx.plugin(AgentLoop, { agents: [] })
|
|
await ctx.plugin(AgentPresets, { default: 'standard', roots: ROOTS })
|
|
await ctx.plugin(InvariantService)
|
|
await ctx.plugin(AgentPresetsInvariant)
|
|
return ctx
|
|
}
|
|
|
|
describe('agent-presets invariants', () => {
|
|
it('keeps the standing composition alive across the agents that joined it', async () => {
|
|
const ctx = await harness()
|
|
const handle = await ctx.agents.create({
|
|
sessionId: SessionId('inv-live'),
|
|
setup: async (agentCtx: Context) => void await ctx.agentPresets.mount(agentCtx, 'standard'),
|
|
})
|
|
|
|
expect(livePresetMounts().map(mount => mount.presetId)).toContain('standard')
|
|
|
|
// A standing mount survives its agents: the composition a session joined
|
|
// is shared, so one session ending must not strip it from the next.
|
|
await handle.dispose()
|
|
expect(livePresetMounts().map(mount => mount.presetId)).toContain('standard')
|
|
|
|
// A second agent reuses the same mount rather than adding one.
|
|
await ctx.agents.create({
|
|
sessionId: SessionId('inv-live-2'),
|
|
setup: async (agentCtx: Context) => void await ctx.agentPresets.mount(agentCtx, 'standard'),
|
|
})
|
|
expect(livePresetMounts().filter(mount => mount.presetId === 'standard')).toHaveLength(1)
|
|
|
|
// Whole-tree teardown is the boundary that does reclaim it.
|
|
await ctx.fiber.dispose()
|
|
expect(livePresetMounts().map(mount => mount.presetId)).not.toContain('standard')
|
|
})
|
|
|
|
it('rejects a composition that publishes a process-global service after its audit', async () => {
|
|
const ctx = await harness()
|
|
await ctx.agents.create({
|
|
sessionId: SessionId('inv-late'),
|
|
setup: async (agentCtx: Context) => void await ctx.agentPresets.mount(agentCtx, 'late'),
|
|
})
|
|
const publishLate = (globalThis as { __PUBLISH_LATE__?: () => void }).__PUBLISH_LATE__
|
|
expect(publishLate).toBeTypeOf('function')
|
|
|
|
expect(() => { publishLate?.() }).toThrow(/published process-global service\(s\) \[fixtureLateSvc\]/)
|
|
})
|
|
|
|
it('stays quiet while every composition keeps its services out of the root realm', async () => {
|
|
const ctx = await harness()
|
|
|
|
await expect(ctx.agents.create({
|
|
sessionId: SessionId('inv-isolated'),
|
|
setup: async (agentCtx: Context) => void await ctx.agentPresets.mount(agentCtx, 'isolated'),
|
|
})).resolves.toBeDefined()
|
|
})
|
|
})
|